Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation buttons #11

Merged
merged 14 commits into from
Dec 29, 2023
Merged

Navigation buttons #11

merged 14 commits into from
Dec 29, 2023

Conversation

JoanaFigueira
Copy link
Contributor

Description

Add navigation buttons to installations' detail page

Changes

  • Add contextProvider

Observations

Please, review

  • List of things authors emphasize to review

How to check the new features

Deploy notes

@JoanaFigueira JoanaFigueira added the enhancement New feature or request label Dec 22, 2023
@vokimon vokimon force-pushed the IMP_navigation_buttons branch from 48f3284 to 2bcab40 Compare December 22, 2023 12:53
@javikalsan javikalsan marked this pull request as ready for review December 26, 2023 22:40
@vokimon vokimon force-pushed the IMP_navigation_buttons branch from 20c89a8 to 097790d Compare December 29, 2023 08:23
@coveralls
Copy link

coveralls commented Dec 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7356253981

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.505%
Totals Coverage Status
Change from base Build 7345228674: -0.2%
Covered Lines: 474
Relevant Lines: 643
💛 - Coveralls

JoanaFigueira and others added 14 commits December 29, 2023 12:36
@JoanaFigueira @javikalsan @vokimon
🚧 Installations Context
8d2b5b1 
Co-authored-by: javikalsan <jcalzadosanchez@gmail.com>
@javikalsan @vokimon
✨ Compute navigation information
a690827 
- Add tests
- Add production code
- Adapt navigation buttons component
@javikalsan @vokimon
🧹 Context proposal cleanup
79fcd20
@vokimon
🐛 dummy install detalls now keeps the contract number
ac2305b
@vokimon
💄 navigation buttons aligned with title
9af465a 
- width was misspelled
@vokimon
🧹 ...{} and ...undefined are equivalents
a69034c 
oxlint warns
@javikalsan @vokimon
✨ Implement installation context
3442de4
@javikalsan @vokimon
✨ Use installation context on installation detail
68436be 
- Add trailing semicolons for better code readability and to avoid potential issues.
@javikalsan @vokimon
✨ Use installation context on installations list
38ce52e 
- Add trailing semicolons for better code readability and to avoid potential issues.
@javikalsan @vokimon
✨ Make context available for specific children
b1aafb2
@javikalsan @vokimon
🐛 Undo setNavigationInfo function
5283fd0
@javikalsan @vokimon
⚡️ Memoize values to prevent unnecessary re-renders
7dd39ad
@vokimon
🎨 using outlets and hierarchy
6d9325a
@vokimon
🐛 alignText -> textAlign
5430ee9
@vokimon vokimon force-pushed the IMP_navigation_buttons branch from 5348ce5 to 5430ee9 Compare December 29, 2023 11:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vokimon vokimon merged commit 9cd6277 into main Dec 29, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vokimon vokimon Awaiting requested review from vokimon

@MariteSomEnergia MariteSomEnergia Awaiting requested review from MariteSomEnergia

Assignees

@javikalsan javikalsan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanaFigueira @coveralls @vokimon @javikalsan